[eas-cli] amend credential removal wording #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinlanj
requested review from
khamilowicz,
sjchmiela and
szdziedzic
as code owners
|
/changelog-entry chore amend credential removal wording |
|
✅ Thank you for adding the changelog entry! |
|
Size Change: +549 B (0%) Total Size: 51.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2334 +/- ##
==========================================
- Coverage 53.67% 53.66% -0.01%
==========================================
Files 525 525
Lines 19256 19264 +8
Branches 4062 4066 +4
==========================================
+ Hits 10334 10336 +2
- Misses 8197 8203 +6
Partials 725 725 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I recently capped the number of Entities we load from www on the ApplePushKey
iosAppCredentialsListedge and the AppleDistributionCertificateiosAppBuildCredentialsListedge because we had some outlier users that had thousands of entities on those edges. We use the edges to tell the user which apps still use the credential when users try to delete it.How
Amend the wording to tell the user that they may have more apps relying on the credential if the
wwwlimit has been hit.Test Plan